Skip to content

Make internally stored default argument values public#1373

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-23.12from
vyasr:feat/public_default_args
Nov 6, 2023
Merged

Make internally stored default argument values public#1373
rapids-bot[bot] merged 3 commits intorapidsai:branch-23.12from
vyasr:feat/public_default_args

Conversation

@vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 2, 2023

Description

There are a couple of default parameters that are being set, one to a local constexpr and another by a method, both of which were previously private. That made the defaults unintentionally opaque. This change makes both of them publicly visible values.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added feature request New feature or request 3 - Ready for review Ready for review by team non-breaking Non-breaking change labels Nov 2, 2023
@vyasr vyasr self-assigned this Nov 2, 2023
@vyasr vyasr requested review from a team as code owners November 2, 2023 22:58
@vyasr vyasr requested review from bdice and wence- November 2, 2023 22:58
@github-actions github-actions bot added Python Related to RMM Python API cpp Pertains to C++ code labels Nov 2, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Nov 6, 2023

/merge

@rapids-bot rapids-bot bot merged commit 28abb10 into rapidsai:branch-23.12 Nov 6, 2023
@vyasr vyasr deleted the feat/public_default_args branch November 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for review Ready for review by team cpp Pertains to C++ code feature request New feature or request non-breaking Non-breaking change Python Related to RMM Python API

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants