Skip to content

Fix else-after-throw clang tidy error#1391

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.02from
harrism:fix-clang-tidy-else-after-throw
Nov 30, 2023
Merged

Fix else-after-throw clang tidy error#1391
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.02from
harrism:fix-clang-tidy-else-after-throw

Conversation

@harrism
Copy link
Member

@harrism harrism commented Nov 28, 2023

Description

Updates code for RMM_CUDA_TRY_ALLOC macro in detail/error.hpp to eliminate a clang-tidy error.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism added bug Something isn't working non-breaking Non-breaking change labels Nov 28, 2023
@harrism harrism requested a review from a team as a code owner November 28, 2023 01:38
@harrism harrism requested review from rongou and vyasr November 28, 2023 01:38
@github-actions github-actions bot added the cpp Pertains to C++ code label Nov 28, 2023
@harrism harrism changed the title Fix else-after-thrown clang tidy error Fix else-after-throw clang tidy error Nov 28, 2023
@harrism harrism self-assigned this Nov 28, 2023
@harrism
Copy link
Member Author

harrism commented Nov 30, 2023

/merge

@rapids-bot rapids-bot bot merged commit ee3817c into rapidsai:branch-24.02 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rongou rongou rongou approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@harrism harrism

Labels

bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change

Projects

RMM Project Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harrism @rongou @vyasr