Merged
Conversation
bdice
added
non-breaking
vyasr
approved these changes
Dec 12, 2025
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
I did a quick skim and it seems fine. I didn't go over it with a fine-tooth comb, I'm trusting that all the tests made it into the new files and that you selected the percents in CMake based on some testing.
Collaborator
Author
Correct! |
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the
MR_REFC++ tests are the largest tests in RMM. I have split this executable up into multiple tests, to make it easier to identify and reproduce problems in new memory resources.Checklist