Adds a linear accessor to RMM cuda stream pool#696
Merged
rapids-bot[bot] merged 10 commits intorapidsai:branch-0.19from Feb 8, 2021
Merged
Adds a linear accessor to RMM cuda stream pool#696rapids-bot[bot] merged 10 commits intorapidsai:branch-0.19from
rapids-bot[bot] merged 10 commits intorapidsai:branch-0.19from
Conversation
jrhemstad
requested changes
Feb 5, 2021
…rmm into fea-stream-pool-linear-accessor
jrhemstad
requested changes
Feb 8, 2021
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
jrhemstad
approved these changes
Feb 8, 2021
harrism
approved these changes
Feb 8, 2021
Member
harrism
left a comment
harrism
left a comment
There was a problem hiding this comment.
Looks good (funny, I had this implemented in a local experimental branch). Just a comment on a test.
harrism
added
improvement
…rmm into fea-stream-pool-linear-accessor
rongou
approved these changes
Feb 8, 2021
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
rmm::cuda_stream_pool::get_stream(stream_id)andrmm::cuda_stream_pool::get_pool_size()accessors which allow legacy compatibility in cuML and immediate adoption ofrmm::cuda_stream_poolin RAFT and cuGraph. This co-exist with the current features inrmm::cuda_stream_pool.close #689