Skip to content

[REVIEW] ENH Build with Ninja & Pass ccache variables to conda recipe#705

Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-0.19from
dillon-cullinan:enh-ninjaccache
Feb 22, 2021
Merged

[REVIEW] ENH Build with Ninja & Pass ccache variables to conda recipe#705
rapids-bot[bot] merged 6 commits intorapidsai:branch-0.19from
dillon-cullinan:enh-ninjaccache

Conversation

@dillon-cullinan
Copy link
Contributor

@dillon-cullinan dillon-cullinan commented Feb 16, 2021

Changes:

  • Enables ninja build system
  • Exposes ccache environment variables to the conda build

These changes are required to allow ccache to function correctly and have a high cache hitrate during builds.

@dillon-cullinan dillon-cullinan requested a review from a team as a code owner February 16, 2021 19:52
@github-actions github-actions bot added the conda label Feb 16, 2021
@github-actions github-actions bot added the gpuCI label Feb 16, 2021
@dillon-cullinan
Copy link
Contributor Author

rerun tests

@github-actions github-actions bot removed the gpuCI label Feb 16, 2021
@dillon-cullinan dillon-cullinan added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 16, 2021
@dillon-cullinan dillon-cullinan changed the title [WIP] ENH Build with Ninja & Pass ccache variables to conda recipe [REVIEW] ENH Build with Ninja & Pass ccache variables to conda recipe Feb 16, 2021
@dillon-cullinan dillon-cullinan requested a review from a team February 16, 2021 21:38
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about configurability.

@github-actions github-actions bot added the gpuCI label Feb 19, 2021
Comment on lines +21 to +27
- CCACHE_DIR
- CCACHE_NOHASHDIR
- CCACHE_COMPILERCHECK
- CMAKE_GENERATOR
- CMAKE_C_COMPILER_LAUNCHER
- CMAKE_CXX_COMPILER_LAUNCHER
- CMAKE_CUDA_COMPILER_LAUNCHER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really make a rapids-build package or something similar that sets these via an activation script instead of passing all of these through the recipe, but we can do that in follow ups I suppose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand what you mean. Are you talking about utilizing this: https://conda.io/projects/conda-build/en/latest/resources/activate-scripts.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly, we could have a package with an activate script that sets all of these environment variables as expected and then depend on the package in the build section or something similar.

@kkraus14
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e737e68 into rapidsai:branch-0.19 Feb 22, 2021
@dillon-cullinan
Copy link
Contributor Author

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants