[REVIEW] ENH Build with Ninja & Pass ccache variables to conda recipe#705
Conversation
|
rerun tests |
harrism
left a comment
There was a problem hiding this comment.
Question about configurability.
| - CCACHE_DIR | ||
| - CCACHE_NOHASHDIR | ||
| - CCACHE_COMPILERCHECK | ||
| - CMAKE_GENERATOR | ||
| - CMAKE_C_COMPILER_LAUNCHER | ||
| - CMAKE_CXX_COMPILER_LAUNCHER | ||
| - CMAKE_CUDA_COMPILER_LAUNCHER |
There was a problem hiding this comment.
We should really make a rapids-build package or something similar that sets these via an activation script instead of passing all of these through the recipe, but we can do that in follow ups I suppose.
There was a problem hiding this comment.
I'm not sure I understand what you mean. Are you talking about utilizing this: https://conda.io/projects/conda-build/en/latest/resources/activate-scripts.html
There was a problem hiding this comment.
Yes exactly, we could have a package with an activate script that sets all of these environment variables as expected and then depend on the package in the build section or something similar.
|
@gpucibot merge |
|
@gpucibot merge |
Changes:
ninjabuild systemccacheenvironment variables to the conda buildThese changes are required to allow
ccacheto function correctly and have a high cache hitrate during builds.