Add Cython definitions for device_uvector#720
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-0.19from Mar 5, 2021
Merged
Add Cython definitions for device_uvector#720rapids-bot[bot] merged 2 commits intorapidsai:branch-0.19from
rapids-bot[bot] merged 2 commits intorapidsai:branch-0.19from
Conversation
kkraus14
reviewed
Mar 5, 2021
Comment on lines
+20
to
+23
| device_buffer release() | ||
| size_t capacity() | ||
| T* data() | ||
| size_t size() |
kkraus14
approved these changes
Mar 5, 2021
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new cuDF join APIs will return gathermaps of type
device_uvector<size_type>>, so we need Cython definitions for it in RMM.