Fix failing stream test with a debug-only death test#934
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.02from Dec 14, 2021
Merged
Fix failing stream test with a debug-only death test#934rapids-bot[bot] merged 1 commit intorapidsai:branch-22.02from
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.02from
Conversation
harrism
added
bug
rongou
approved these changes
Dec 14, 2021
Contributor
|
rerun tests |
codereport
approved these changes
Dec 14, 2021
Member
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #932. Adds a debug-build-only death test for
cuda_stream::synchronize_no_throwand adds a likely never to fail trivial test of the function in all builds. This way we get coverage of the function in all builds, and can safely test its assertion in debug builds.