drm/vc4: Skip input lines when doing a large downscale #7195
Conversation
The TPZ filter wants ideally 3 lines of image to give good quality downscaling. More than that leads to excessive SDRAM bandwidth for no gain. If the downsample factor allows for it, reduce the programmed image height and increase the pitch to compensate. This currently does not handle T-format images where we need to configure it slightly differently. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
Now fixed up for SAND and tested on Pi4 and Pi5. I haven't got an easy way to test T-format, so have left the behaviour as-is with a comment. |
|
Is T-format documented anywhere? I could build something to test it into
10bittest
…On Thu, 22 Jan 2026 at 16:49, 6by9 ***@***.***> wrote:
*6by9* left a comment (raspberrypi/linux#7195)
<#7195 (comment)>
Now fixed up for SAND and tested on Pi4 and Pi5.
I haven't got an easy way to test T-format, so have left the behaviour
as-is with a comment.
—
Reply to this email directly, view it on GitHub
<#7195 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADV4O4OW2ICLOGGQRIRSM634ID5TBAVCNFSM6AAAAACRSNKUBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOBVGQ3TCNRXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
T format is only used with the Pi0-3 3D unit. Basic description is in https://github.com/torvalds/linux/blob/master/include/uapi/drm/drm_fourcc.h#L1090-L1108. We can probably find some Broadcom docs if needed. ... Found in the HVS docs for 2708 (Pi1)
I take that as meaning it's really not worth pursuing. As long as you don't manage to break this for any of your test cases with linear or SAND, then I'm happy. |
2 participants
Draft PR for @jc-kynesim to test whilst I fix up SAND and T-Format handling.
The TPZ filter wants ideally 3 lines of image to give good quality downscaling. More than that leads to excessive SDRAM bandwidth for no gain.
If the downsample factor allows for it, reduce the programmed image height and increase the pitch to compensate.
FIXME: This currently does not handle SAND or T-format images where we need to configure it slightly differently.