-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Adds a driver for the new series of Studio DAC8x soundcards #7197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rpi-6.12.y
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // SPDX-License-Identifier: GPL-2.0 | ||
| // Definitions for HiFiBerry Studio DAC8x soundcard | ||
| /dts-v1/; | ||
| /plugin/; | ||
|
|
||
| / { | ||
| compatible = "brcm,bcm2712"; | ||
|
|
||
| fragment@0 { | ||
| target = <&i2c1>; | ||
| __overlay__ { | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@1 { | ||
| target = <&gpio>; | ||
| __overlay__ { | ||
| rp1_i2s0_dac8x: rp1_i2s0_dac8x { | ||
| function = "i2s0"; | ||
| pins = "gpio18", "gpio19", "gpio20", | ||
| "gpio21", "gpio22", "gpio23", | ||
| "gpio24", "gpio25", "gpio26", | ||
| "gpio27"; | ||
| bias-disable; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@2 { | ||
| target = <&i2s_clk_producer>; | ||
| __overlay__ { | ||
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&rp1_i2s0_dac8x>; | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@3 { | ||
| target-path = "/"; | ||
| __overlay__ { | ||
| dummy-codec { | ||
| #sound-dai-cells = <0>; | ||
| compatible = "snd-soc-dummy"; | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@4 { | ||
| target = <&sound>; | ||
| __overlay__ { | ||
| compatible = "hifiberry,hifiberry-studio-dac8x"; | ||
| i2s-controller = <&i2s_clk_producer>; | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
|
|
||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // SPDX-License-Identifier: GPL-2.0 | ||
| // Definitions for HiFiBerry Studio DAC8x PRO soundcard | ||
| /dts-v1/; | ||
| /plugin/; | ||
|
|
||
| / { | ||
| compatible = "brcm,bcm2712"; | ||
|
|
||
| fragment@0 { | ||
| target = <&i2c1>; | ||
| __overlay__ { | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@1 { | ||
| target = <&gpio>; | ||
| __overlay__ { | ||
| rp1_i2s1_dac8x: rp1_i2s1_dac8x { | ||
| function = "i2s1"; | ||
| pins = "gpio18", "gpio19", "gpio20", | ||
| "gpio21", "gpio22", "gpio23", | ||
| "gpio24", "gpio25", "gpio26", | ||
| "gpio27"; | ||
| bias-disable; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@2 { | ||
| target = <&i2s_clk_consumer>; | ||
| __overlay__ { | ||
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&rp1_i2s1_dac8x>; | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@3 { | ||
| target-path = "/"; | ||
| __overlay__ { | ||
| dummy-codec { | ||
| #sound-dai-cells = <0>; | ||
| compatible = "snd-soc-dummy"; | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@4 { | ||
| target = <&sound>; | ||
| __overlay__ { | ||
| compatible = "hifiberry,hifiberry-studio-dac8x"; | ||
| i2s-controller = <&i2s_clk_consumer>; | ||
| clk-provider; | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
|
|
||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1157,6 +1157,7 @@ CONFIG_SND_BCM2708_SOC_HIFIBERRY_DACPLUSHD=m | |
| CONFIG_SND_BCM2708_SOC_HIFIBERRY_DACPLUSADC=m | ||
| CONFIG_SND_BCM2708_SOC_HIFIBERRY_DACPLUSADCPRO=m | ||
| CONFIG_SND_BCM2708_SOC_HIFIBERRY_DACPLUSDSP=m | ||
| CONFIG_SND_BCM2708_SOC_HIFIBERRY_STUDIO_DAC8X=m | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you should also add this to bcm2711_defconfig, which runs happily on Pi 5, just with 4kB pages instead of 16kB.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see that bcm2711 kernel runs on a Pi 5 but our driver does not support Pi 4 as it's made for multi channel audio (only).
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's not a problem. All the kernels have support for lots of hardware that most people don't have, which is fine if the drivers are modules. |
||
| CONFIG_SND_BCM2708_SOC_HIFIBERRY_DIGI=m | ||
| CONFIG_SND_BCM2708_SOC_HIFIBERRY_AMP=m | ||
| CONFIG_SND_BCM2708_SOC_PIFI_40=m | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would not be necessary if the Pro had a different compatible string, but you may have reasons to prefer doing it like this - I'm not really bothered either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep it as is. It seems the easiest and simple way for us.