fix: hint_inline treats 'eol' and 'right_align' as 'inline'#363
Merged
ray-x merged 1 commit intoray-x:masterfrom May 19, 2025
Merged
fix: hint_inline treats 'eol' and 'right_align' as 'inline'#363ray-x merged 1 commit intoray-x:masterfrom
hint_inline treats 'eol' and 'right_align' as 'inline'#363ray-x merged 1 commit intoray-x:masterfrom
Conversation
The official documentation says that the `hint_inline` function should return 'eol' to place the hint at the end of the line or 'right_align' to align the hint to the right of the line. However, even if the function returns 'eol' or 'right_align', the hint will always be inline
Owner
|
Thanks! It was a test feature, so the logic doesn't quite match the document, but I am happy to merge it. |
ray-x
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official documentation says that the
hint_inlinefunction should return 'eol' to place the hint at the end of the line or 'right_align' to align the hint to the right of the line. However, even if the function returns 'eol' or 'right_align', the hint will always be inlineIs this the desired behavior?