Skip to content

fix character index calculation considering LSP offset encoding #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sskroi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix character index calculation considering LSP offset encoding #364

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16b8de1
fix: incorrect calculation of line character index
sskroi Apr 21, 2025
5f55dab
Merge branch 'ray-x:master' into master
sskroi Jun 3, 2025
d594800
fix character index calculation considering LSP offset encoding
sskroi Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: incorrect calculation of line character index
  • Loading branch information
@sskroi
sskroi committed Apr 21, 2025
commit 16b8de150d38ddf27bfd4c4597740f0a21fef87a
2 changes: 1 addition & 1 deletion lua/lsp_signature/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ local signature = function(opts)
end
end

local shift = math.max(1, trigger_position - 0)
local shift = math.max(0, trigger_position - 0)
local params = helper.make_position_params({
position = {
character = shift,
Expand Down
Loading