[Examples] Warning fixes (pt 1)#1668
Merged
raysan5 merged 2 commits intoraysan5:masterfrom Mar 23, 2021
Merged
Conversation
raysan5
reviewed
Mar 22, 2021
| Color ballColor = BEIGE; | ||
|
|
||
| int touchCounter = 0; | ||
| float touchCounter = 0; |
Owner
There was a problem hiding this comment.
Why it should be a float? It's just a counter...
| // Draw RenderTexture2D to window, properly scaled | ||
| DrawTexturePro(target.texture, (Rectangle){ 0.0f, 0.0f, (float)target.texture.width, (float)-target.texture.height }, | ||
| (Rectangle){ (GetScreenWidth() - ((float)gameScreenWidth*scale))*0.5, (GetScreenHeight() - ((float)gameScreenHeight*scale))*0.5, | ||
| (Rectangle){ (GetScreenWidth() - ((float)gameScreenWidth*scale))*0.5, (GetScreenHeight() - ((float)gameScreenHeight*scale))*0.5f, |
Owner
There was a problem hiding this comment.
Probably the width multiplier should also be 0.5f.
| Model model1 = LoadModelFromMesh(torus); | ||
|
|
||
| Mesh cube = GenMeshCube(.8,.8,.8); | ||
| Mesh cube = GenMeshCube(.8f,.8f,.8f); |
Owner
There was a problem hiding this comment.
Oh, I didn't see those ones before, could you change them to:
Mesh cube = GenMeshCube(0.8f, 0.8f, 0.8f);| int colorSelectedPrev = colorSelected; | ||
| int colorMouseHover = 0; | ||
| int brushSize = 20; | ||
| float brushSize = 20; |
Owner
|
@JeffM2501 Thanks for the review, added some comments. |
Owner
|
@JeffM2501 Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings in several examples in visual studio 2019