Fix Vector2Angle()#2829
Merged
raysan5 merged 1 commit intoraysan5:masterfrom Dec 13, 2022
AlxHnr:master
Merged
Conversation
With this fix the function still returns negative values, which is wrong. But we keep this behaviour to maintain backwards compatibility.
Owner
|
@AlxHnr Thanks for the review, actually I think this function has already been reviewed several times... |
Contributor
|
The fact that it only works with normalized vectors is not documented anywhere. Can we get the proper fix? Even if it breaks compatibility? acos(clamp(dot(v1, v2), -1, 1)) |
Contributor
Author
|
You are right, it would be better if we would support everything we throw at it. Usually it just needs an extra division and thats it. I'll reopen my original ticket. |
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix ensures that the angle can be computed for all normalized vectors. But we still return negative values, which is not correct, but is required to maintain backwards compatibility.
Fixes #2828