Update rmodels.c; free fileData for LoadModelAnimationsGLTF#3065
Merged
raysan5 merged 1 commit intoraysan5:masterfrom May 15, 2023
Merged
Update rmodels.c; free fileData for LoadModelAnimationsGLTF#3065raysan5 merged 1 commit intoraysan5:masterfrom
raysan5 merged 1 commit intoraysan5:masterfrom
Conversation
fileData wasn't freed for LoadModelAnimationsGLTF causing a memory leak. Added UnloadFileData line, freeing it.
Owner
|
@crynux Wow! Good catch! Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fileData wasn't freed for LoadModelAnimationsGLTF causing a memory leak. Added UnloadFileData line, freeing it.
With a test of just loading and unloading animations from a glb file; this change clears up the following memory leak reported via valgrind.
becomes
I'm unsure if there's anything else to be aware of in the block of code preceding the change; please let me know if there is.
Thanks!