Re-fix DrawBillboardPro to allow source of negative size (#3197)#3203
Merged
raysan5 merged 1 commit intoraysan5:masterfrom Jul 26, 2023
bohonghuang:billboard-fix
Merged
Re-fix DrawBillboardPro to allow source of negative size (#3197)#3203raysan5 merged 1 commit intoraysan5:masterfrom bohonghuang:billboard-fix
DrawBillboardPro to allow source of negative size (#3197)#3203raysan5 merged 1 commit intoraysan5:masterfrom
bohonghuang:billboard-fix
Conversation
Owner
|
@bohonghuang Nice! Thank you very much for this improvement! :) |
Contributor
Author
|
My pleasure :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause of issue #3197 seems to be that having only one dimension with a negative value in
sourceorsizecauses the vertex order of the billboard to become clockwise, which cannot be rendered correctly when backface culling is enabled. This PR should allowsourceandsizewith any negative dimensions to be rendered correctly, and flipped as expected.