fix(sdk): use setOrganizationMemberRole RPC in update role dialog#1628
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbitRefactor
WalkthroughThis PR refactors the organization member role update flow from client-side policy management (query, delete, create) to a direct role-setting RPC call. It also removes an unused import from the remove-member dialog. The update-role dialog now uses ChangesMember Dialog Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 26148345769Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 42.592%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Summary
listPolicies→deletePolicy→createPolicysequence in the views-new update role dialog with a singlesetOrganizationMemberRoleRPC call, matching the migration already done in the legacy views.Policytype fromupdate-role-dialog.tsx.handleConnectErrormapping, and toast behaviour unchanged.