-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add metric widget to Explorer visualization for Interval & GroupBy None #107
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## rzp_main #107 +/- ##
============================================
- Coverage 81.91% 79.82% -2.09%
============================================
Files 931 933 +2
Lines 20013 20133 +120
Branches 2708 2740 +32
============================================
- Hits 16393 16071 -322
- Misses 3472 3891 +419
- Partials 148 171 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jaywalker21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comms
| this.requestSubject.next(request); | ||
| } | ||
|
|
||
| private getLayoutForElements(numberOfElements: number): object { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can automate this?
Also, if not automate, reuse the other parts apart from the cell-span thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a function to generate column dimensions since they're all the same.
Not sure if one for row dimensions is possible since rows are unequal for less than 5 elements and equal afterwards.
For cell spans, can probably write a function to decrease lines of code but it'll get harder to read and modify code later. Should I add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for rows, we are showing 4 items per row right? If that value is static, the row thing can be automated too. If you're disabling the option to add more values beyond a certain count, I am fine with things being static in code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not always, here's the layout:
| No. of metrics | Grid used | Position of items | Row height |
|---|---|---|---|
| 1 | 3 x 3 | Single item in the middle cell, other cells empty | middle row is bigger |
| 2 to 4 | 3 x 4 | 4 items in the middle row, top & bottom row empty | middle row is bigger |
| 5 to 8 | 2 x 4 | 4 items each in two rows, full grid filled | rows are equal height |
All layouts have different combination of rows & columns. Not sure what's the cap we should have for number of metrics. It's not a limitation really, I can keep adding more grid layouts but do we know any teams using panels with more than 8 metrics?
The chart height also can be changed depending on how many metrics we want to fit. Like if someone really wants 30 metrics in a panel, the height can be increased to fit more but then time series charts will also become bigger permanently.
projects/observability/src/pages/explorer/explorer-dashboard-builder.ts
Outdated
Show resolved
Hide resolved
...servability/src/shared/dashboard/data/graphql/explore/explore-cartesian-data-source.model.ts
Show resolved
Hide resolved
...cts/observability/src/shared/dashboard/widgets/metric-display/metric-display-widget.model.ts
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 4 files ±0 303 suites +1 24m 52s ⏱️ +44s For more details on these failures, see this check. Results for commit 34afe6b. ± Comparison against base commit 55c6cc3. |
Description
Jira | Stage environment
Testing
Checklist: