Skip to content

Proof of concept#1

Closed
edahlseng wants to merge 3 commits into
mainfrom
eric/proof-of-concept
Closed

Proof of concept#1
edahlseng wants to merge 3 commits into
mainfrom
eric/proof-of-concept

Conversation

@edahlseng
Copy link
Copy Markdown
Collaborator

@edahlseng edahlseng commented Feb 17, 2025

Hi @rbbydotdev, here's a proof of concept that I put together for us to align on the overall approach for this repository. It's hacky in places and doesn't handle all edge cases, but it proves out the concept. Before I start cleaning it up, please take a look and let me know what you think! A few specific notes and questions:

  • Thanks for the tip to use @clack/prompts, it's super easy to use and looks great! I've used commander for parsing arguments.
  • The CLI current looks for an optional filepath argument. If one is present, then it will attempt to create a deployment based on the JSON configuration in that file, but if no argument is provided, then the CLI will enter a wizard prompting mode.
  • The configuration file is used to store all of the scheduling preferences, and once a new Google Apps Script project is made, the scriptId will be added to the configuration file for reference during future deployments.
  • I also added the backend and frontend sources from someday in the first commit in this PR – I found it more intuitive to have all of the sources in this repository, with the intent being that everything is built and deployed in a single NPM package. I know you were thinking about keeping those sources in the other repository, though, so please take a look and let me know what you think!
  • During the cleanup phase for this PR, I'm planning on pulling the prettier config from someday and setting up Typescript for consistency.
Screen.Recording.2025-02-16.at.20.51.16.mov

@edahlseng edahlseng requested a review from rbbydotdev February 17, 2025 05:05
@rbbydotdev
Copy link
Copy Markdown
Owner

Hey this is really great! I'm still a bit busy at the moment. I will have a closer look within the next few days or so

@rbbydotdev
Copy link
Copy Markdown
Owner

rbbydotdev commented Feb 27, 2025

I want to walk back on my previous notion on how the package was setup. Someday should be a mono repo after all. Apologies for the extra work ;) Could you make this pull request to the main someday repo? I would eventually like everything to live in /package (/package/frontend,/package/backend,/package/cli) Generally making the setup the same as https://github.com/vercel/next.js This should make managing everything much much easier as a monorepo.
As far as the monorepo tool, I'm not sure which would be best - what do you think Nx, Turborepo something else?

@edahlseng
Copy link
Copy Markdown
Collaborator Author

No worries, sounds good to me! I'll resubmit this PR to the main someday repo momentarily.

I don't have any direct experience with Nx or Turborepo, so let's use whatever you recommend! After a quick search of the two tools, I lean towards Turborepo for this project, but that's just a superficial leaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants