Added logic for wifi reassociation#291
Merged
gururaajar merged 1 commit intotopic/RDK-59986from Mar 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the networkstats plugin’s WiFi reassociation behavior by replacing a direct wpa_cli reassociate shell call with a Thunder NetworkManager RPC (WiFiConnect) intended to reconnect to the last saved SSID.
Changes:
- Add
invokeWiFiConnect()toINetworkDataand implement it in both Thunder JSON-RPC and COM-RPC providers. - Switch WiFi reassociation path to call
m_provider->invokeWiFiConnect()instead of executingwpa_cli.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| networkstats/plugin/INetworkData.h | Adds a new provider API for triggering WiFi reconnect via NetworkManager. |
| networkstats/plugin/ThunderJsonRPCProvider.h | Declares invokeWiFiConnect() on the JSON-RPC provider. |
| networkstats/plugin/ThunderJsonRPCProvider.cpp | Implements invokeWiFiConnect() via Thunder JSON-RPC Invoke("WiFiConnect"). |
| networkstats/plugin/ThunderComRPCProvider.h | Declares invokeWiFiConnect() on the COM-RPC provider. |
| networkstats/plugin/ThunderComRPCProvider.cpp | Implements invokeWiFiConnect() via Thunder COM-RPC Invoke("WiFiConnect"). |
| networkstats/plugin/NetworkConnectionStatsImplementation.cpp | Replaces system("wpa_cli reassociate") with invokeWiFiConnect(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+374
to
+377
| if (rc == WPEFramework::Core::ERROR_NONE) { | ||
| NSLOG_INFO("WiFiConnect invoked successfully on NetworkManager"); | ||
| } else { | ||
| NSLOG_ERROR("WiFiConnect invocation failed with error code: %u", rc); |
Comment on lines
+386
to
+395
| uint32_t rc = m_networkManagerClient->Invoke<WPEFramework::Core::JSON::VariantContainer, WPEFramework::Core::JSON::VariantContainer>( | ||
| 5000, "WiFiConnect", params, result); | ||
|
|
||
| if (rc == WPEFramework::Core::ERROR_NONE) { | ||
| NSLOG_INFO("WiFiConnect invoked successfully on NetworkManager"); | ||
| } else { | ||
| NSLOG_ERROR("WiFiConnect invocation failed with error code: %u", rc); | ||
| } | ||
|
|
||
| return rc; |
gururaajar
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.