fix: get correct values from 'getTabSize' in older browsers#694
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FeNoMeNa
force-pushed
the
fix_get_tab_size
branch
from
cc50b2d to
cde9b2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some older browsers (e.g. Chrome 45) don't support x and y properties as part of the
DOMRectobject returned from getBoundingClientRect. This is a problem because getTabSize returns wrong values which produces visual inconsistencies, so in this MR I'm replacing the x with left and y with top.