Skip to content

chore: update maintenance dependencies#367

Open
afc163 wants to merge 4 commits into
masterfrom
codex/update-maintenance-deps
Open

chore: update maintenance dependencies#367
afc163 wants to merge 4 commits into
masterfrom
codex/update-maintenance-deps

Conversation

@afc163

@afc163 afc163 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Link the Ant Design ecosystem logo in README files to https://ant.design
  • Update React, React DOM, TypeScript, ESLint, Testing Library, @types/, @typescript-eslint/, lint-staged, and related lint dependencies
  • Add ESLint flat config compatibility for ESLint 9 and TypeScript ESLint 8
  • Use grouped Dependabot updates for npm and GitHub Actions

Test Plan

  • npm run lint
  • npm run tsc

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/react-component?upgradeToPro=build-rate-limit

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@afc163, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3fb81326-48b0-4f72-a92b-c9286dd999cc

📥 Commits

Reviewing files that changed from the base of the PR and between cf92789 and b99f263.

📒 Files selected for processing (11)
  • .github/dependabot.yml
  • README.md
  • README.zh-CN.md
  • eslint.config.mjs
  • examples/no-virtual.tsx
  • examples/switch.tsx
  • global.d.ts
  • package.json
  • react-compat.d.ts
  • src/Item.tsx
  • tsconfig.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/update-maintenance-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

socket-security Bot commented Jun 29, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project to support React 19 and TypeScript 6, which includes upgrading dependencies, migrating to ESLint's flat configuration, refactoring components to use React.forwardRef, and adding compatibility type declarations. Feedback on these changes highlights several type safety and compatibility concerns: declaring the deprecated hydrate method in react-dom risks runtime errors in React 19, overriding Jest globals with any disables type safety in tests, disabling @typescript-eslint/no-unused-vars globally can lead to dead code, and disabling strict compiler flags in tsconfig.json significantly reduces type safety.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread react-compat.d.ts
Comment on lines +14 to +16
declare module 'react-dom' {
function hydrate(element: React.ReactNode, container: Element | DocumentFragment): void;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Declaring hydrate in react-dom is highly risky because ReactDOM.hydrate has been completely removed in React 19. If any code or dependency attempts to call hydrate at runtime, it will throw a TypeError. You should migrate any remaining usage of hydrate to hydrateRoot from react-dom/client instead of declaring it here.

Comment thread global.d.ts Outdated
Comment on lines +47 to +54
declare const describe: any;
declare const it: any;
declare const test: any;
declare const beforeEach: any;
declare const afterEach: any;
declare const beforeAll: any;
declare const afterAll: any;
declare const expect: any;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since jest types are already referenced at the top of this file (/// <reference types="jest" />), declaring these testing globals as any is redundant and overrides Jest's strongly-typed definitions with any. This disables type checking in your test files. Consider removing these declarations to preserve type safety.

Comment thread eslint.config.mjs
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/no-empty-object-type': 'off',
'@typescript-eslint/no-unsafe-function-type': 'off',
'@typescript-eslint/no-unused-vars': 'off',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Disabling @typescript-eslint/no-unused-vars globally is not recommended as it can lead to dead code and undetected bugs. Consider setting it to 'warn' or configuring it to ignore variables prefixed with an underscore.

Suggested change
'@typescript-eslint/no-unused-vars': 'off',
'@typescript-eslint/no-unused-vars': 'warn',

Comment thread tsconfig.json Outdated
Comment on lines +28 to +34
"noImplicitAny": false,
"strictNullChecks": false,
"strictPropertyInitialization": false,
"strictFunctionTypes": false,
"strict": false,
"noImplicitThis": false,
"strictBindCallApply": false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Disabling strict mode and other strict type-checking flags (noImplicitAny, strictNullChecks, etc.) significantly reduces type safety and can allow runtime bugs to slip through. It is highly recommended to keep strict: true enabled and resolve the individual type errors, especially for a library package.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

React Doctor found 1 issue in 1 file · 1 warning · score 77 / 100 (Needs work) · vs master

1 warning

src/Item.tsx

  • ⚠️ L11 Missing effect dependencies exhaustive-deps

Reviewed by React Doctor for commit b99f263. See inline comments for fixes.

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
virtual-list Ready Ready Preview, Comment Jun 30, 2026 3:10am

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

❌ Deploy failed

PR preview ❌ Failed ❌ Failed
🔗 Preview https://react-component-virtual-list-preview-pr-367.surge.sh (may be unavailable)
📝 Commitb99f263
🪵 LogsView logs
📋 Build log (last lines)
npm warn exec The following package was not found and will be installed: surge@0.27.4

   Running as afc163@gmail.com (Student)

        project: ./docs-dist
         domain: react-component-virtual-list-preview-pr-367.surge.sh
           size: 52 files, 1.9 MB

   Aborted - you do not have permission to publish to react-component-virtual-list-preview-pr-367.surge.sh

🤖 Powered by surge-preview

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (cf92789) to head (b99f263).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          19       19           
  Lines         800      800           
  Branches      193      195    +2     
=======================================
  Hits          780      780           
  Misses         20       20           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/afc163s-projects?upgradeToPro=build-rate-limit

Comment thread src/Item.tsx
@@ -10,7 +10,7 @@ export function Item({ children, setRef }: ItemProps) {
setRef(node);
}, []);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Doctor · react-doctor/exhaustive-deps (warning)

useCallback can run with a stale setRef & show your users old data.

Fix → Don't blindly add missing dependencies. Read the hook callback first.

Bad:
useEffect(() => {
setCount(count + 1);
}, [count]);

Better:
useEffect(() => {
setCount((currentCount) => currentCount + 1);
}, []);

If the missing value is recreated every render, move it inside the hook or stabilize it before adding it to deps.

Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant