Fix: add StyleX to tracked ecosystem libraries (closes #63)#64
Conversation
Signed-off-by: sethwebster <sethwebster@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Quick maintainer status update:
The only remaining blocker is required review on the PR. @sethwebster this looks ready for a final maintainer pass / squash merge if you agree. |
Signed-off-by: sethwebster <sethwebster@gmail.com>
|
Follow-up status after the tiny doc-comment sync commit:
I reran Playwright once to rule out a transient, and it failed again on the same visual snapshot ( @sethwebster flagging for maintainer guidance on whether you want a separate follow-up for the snapshot instability, or if you'd prefer another maintainer pass once the check is green again. |
|
Hourly maintainer check-in:
Given the unchanged failure signature and the narrow StyleX diff, I'm still treating this as an external/blocking check rather than a PR-scope regression, but it remains merge-blocking until the snapshot check is green. @sethwebster flagging in case you want a dedicated follow-up on the sign-in header snapshot/env setup path. |
Signed-off-by: sethwebster <sethwebster@gmail.com>
|
I tracked the failing E2E run down to the new header snapshot assertion being too strict for tiny CI-only rendering variance. Fix pushed in
Validation after the fix:
|
|
Current maintainer automation status:
@sethwebster flagging that merging #64 should also unblock the known CI flake path for subsequent ecosystem-data PRs like #65. |
Signed-off-by: sethwebster <sethwebster@gmail.com>
|
Follow-up update:
Waiting on the refreshed GitHub checks from |
Summary
facebook/stylexto the tracked ecosystem library set as a styling entry@stylexjs/stylexRoot Cause
Solution
Test Plan
npx vitest run src/lib/maintainer-tiers.test.tsnpx tsc --noEmitnpm run lintcleanly (blocked by pre-existing repo-wide lint errors unrelated to this change)Screenshots