Skip to content

Fix: add React Strict DOM to tracked ecosystem libraries (closes #62)#65

Merged
sethwebster merged 1 commit into
mainfrom
fix/issue-62
May 15, 2026
Merged

Fix: add React Strict DOM to tracked ecosystem libraries (closes #62)#65
sethwebster merged 1 commit into
mainfrom
fix/issue-62

Conversation

@dougbot-agent

Copy link
Copy Markdown
Collaborator

Summary

  • add facebook/react-strict-dom to the tracked ecosystem library set as a core entry
  • map the repository to the canonical npm package react-strict-dom
  • update related display, probe, and loader datasets so React Strict DOM appears consistently

Root Cause

  • the tracked ecosystem datasets did not include React Strict DOM, so the repository, npm mapping, and derived library datasets could not recognize it

Solution

  • wrote a regression test covering the React Strict DOM repository entry, npm mapping, display name, probe repo list, and libraries loader
  • added the minimal data entries required across the tracked ecosystem sources to satisfy that test

Test Plan

  • Added a failing regression test for React Strict DOM dataset coverage
  • Verified the new test failed before implementation
  • Implemented the minimal fix to make the regression pass
  • Ran npx vitest run src/lib/maintainer-tiers.test.ts
  • Ran npx tsc --noEmit
  • Ran focused ESLint on touched files
  • Ran full npm run lint cleanly (blocked by pre-existing repo-wide lint errors unrelated to this change)

Screenshots

  • N/A (data-only change)

@vercel

vercel Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-foundation Ready Ready Preview, Comment May 14, 2026 0:25am

Request Review

@dougbot-agent

Copy link
Copy Markdown
Collaborator Author

Status update:

  • The React Strict DOM data change itself is still small/scoped, and local focused validation passed (vitest, tsc, touched-file eslint).
  • CI is currently blocked by the same unrelated header snapshot failure we saw earlier: e2e/sign-in-button.spec.ts is failing at the strict header-sign-in.png check with a 192-pixel diff in Linux CI.
  • PR Fix: add StyleX to tracked ecosystem libraries (closes #63) #64 already contains the small snapshot-tolerance adjustment that made this check go green there.

Because this PR was intentionally kept scoped to the React Strict DOM data addition, I'm not auto-bundling that unrelated test change here without maintainer direction. @sethwebster if you want, the cleanest path is likely to merge #64 first and then rebase/refresh #65 against main; otherwise I can carry the same tiny Playwright tolerance fix into this branch as a follow-up.

@dougbot-agent

Copy link
Copy Markdown
Collaborator Author

Hourly maintainer check-in:

  • Re-ran the failing playwright job once from the current PR head; it failed again on the same header snapshot assertion in e2e/sign-in-button.spec.ts (header-sign-in.png, 192px diff).
  • The React Strict DOM diff remains small and scoped, and prior PR-local focused validation for the actual change passed (npx vitest run src/lib/maintainer-tiers.test.ts, npx tsc --noEmit, touched-file eslint).
  • PR Fix: add StyleX to tracked ecosystem libraries (closes #63) #64 is currently green and already contains the narrow snapshot-tolerance change that matches this exact failure signature.

Given the unchanged failure on rerun and the narrow data-only diff here, I'm still treating this as an external/blocking check rather than a PR-scope regression. @sethwebster the cleanest path still looks like merging #64 first, then rebasing/refreshing #65 onto main so it can pick up the snapshot stabilization without bundling unrelated changes into this branch.

@dougbot-agent

Copy link
Copy Markdown
Collaborator Author

Current status after the latest hourly sweep:

Conservative next step: merge #64 first, then refresh/rebase #65 onto main so it picks up the stabilization without bundling unrelated follow-up changes into this branch. @sethwebster flagging for merge/review sequencing.

Signed-off-by: sethwebster <sethwebster@gmail.com>
@dougbot-agent

Copy link
Copy Markdown
Collaborator Author

Rebased this branch onto current main after #64 merged so it now carries the already-accepted Playwright snapshot tolerance update from that PR instead of staying blocked on the stale header snapshot failure.

Local verification on the rebased head passed:

  • npx vitest run src/lib/maintainer-tiers.test.ts
  • npx tsc --noEmit
  • focused eslint on touched files

CI is re-running on the refreshed head now.

@dougbot-agent

Copy link
Copy Markdown
Collaborator Author

Rebased branch is now green:

  • playwright passed
  • DCO passed
  • claude-review passed
  • Vercel preview is ready

I also re-ran the focused local verification on the refreshed head (vitest, tsc, focused eslint).

I can't approve this PR because GitHub blocks the PR author from self-approving, so the remaining step is maintainer review/merge. @sethwebster this looks ready for squash merge if you agree with the scoped data-only change.

@dougbot-agent

Copy link
Copy Markdown
Collaborator Author

@sethwebster final hourly sweep: PR #65 is still small/scoped, all checks are green (playwright, DCO, claude-review, Vercel), and there are no review threads. I attempted the squash merge, but branch protection still requires one approving review from a writer. This should be ready for your approval + squash merge when convenient.

@dougbot-agent

Copy link
Copy Markdown
Collaborator Author

Correction to the prior comment: the shell expanded inline backticks, so here is the clean status update.

Re-checked this on the current head:

  • local focused verification passed again (npx vitest run src/lib/maintainer-tiers.test.ts, npx tsc --noEmit, touched-file eslint)
  • all GitHub checks are still green (playwright, DCO, claude-review, Vercel)
  • there are still no review threads

I tried the squash merge, but branch protection still blocks it because the PR needs an approving review from a writer, and this repo does not have auto-merge enabled.

@sethwebster this looks ready for approval + squash merge when convenient.

@dougbot-agent

Copy link
Copy Markdown
Collaborator Author

Quick maintainer pass from automation:

Attempted squash merge, but the base branch policy blocked it and auto-merge is disabled for this repo. @sethwebster this looks ready for final maintainer review/merge when convenient.

@dougbot-agent

Copy link
Copy Markdown
Collaborator Author

@sethwebster final hourly sweep: all checks are green, there are no open review threads, and focused local validation (npx vitest run src/lib/maintainer-tiers.test.ts --project unit, npx tsc --noEmit, touched-file eslint) passed. This looks ready for approval + squash merge when you are comfortable.

@sethwebster sethwebster merged commit 06e7a00 into main May 15, 2026
7 checks passed
@sethwebster sethwebster deleted the fix/issue-62 branch May 15, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants