Skip to content

Fix: return and display community submission confirmation ID (closes #66)#68

Merged
sethwebster merged 1 commit into
mainfrom
fix/issue-66
May 15, 2026
Merged

Fix: return and display community submission confirmation ID (closes #66)#68
sethwebster merged 1 commit into
mainfrom
fix/issue-66

Conversation

@dougbot-agent

Copy link
Copy Markdown
Collaborator

Summary

  • return the generated submission ID from POST /api/communities/submit
  • display that confirmation ID in the add-community success state for follow-up
  • add regression coverage for both the route response and the client success UI

Root Cause

The submission flow already generated a unique submission-* ID server-side, but the API dropped it from the success response and the client had no way to surface it. Users could see a success message without retaining any durable reference for later follow-up.

Solution

  • include submissionId in the successful route response
  • extend the add-community form success state to render the returned confirmation ID
  • keep failure behavior unchanged while tightening the client catch typing and using semantic success tokens in the UI

Test Plan

  • Wrote failing tests first for the route response and form success UI
  • Verified the new tests failed for the expected missing-confirmation-ID behavior
  • Implemented the minimal fix to return and render the confirmation ID
  • Re-ran targeted regression tests and they passed
  • Ran the full unit test project and it passed
  • Ran npx tsc --noEmit
  • Ran targeted lint checks on touched files

Validation

  • npx vitest run src/app/api/communities/submit/route.test.ts src/components/communities/AddCommunityForm.test.tsx --project unit --silent
  • npx vitest run --project unit --silent
  • npx tsc --noEmit
  • npm run lint -- --max-warnings=0 src/app/api/communities/submit/route.ts src/components/communities/AddCommunityForm.tsx src/app/api/communities/submit/route.test.ts src/components/communities/AddCommunityForm.test.tsx

Signed-off-by: sethwebster <sethwebster@gmail.com>
@vercel

vercel Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-foundation Ready Ready Preview, Comment May 15, 2026 7:00pm

Request Review

@dougbot-agent

Copy link
Copy Markdown
Collaborator Author

@sethwebster All CI checks are green on this automation-authored PR, but branch policy still requires a separate approval before merge. This is scoped just to returning + displaying the community submission confirmation ID for #66, with regression tests in place.

@dougbot-agent dougbot-agent requested a review from sethwebster May 15, 2026 20:09
@sethwebster sethwebster merged commit e2b1d2a into main May 15, 2026
7 checks passed
@sethwebster sethwebster deleted the fix/issue-66 branch May 15, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants