refactor: unify APK building and installing process by krizzu · Pull Request #1055 · react-native-community/cli

krizzu · 2020-03-17T11:32:47Z

Summary:

Hey!

While working on #1038, I've noticed that there are two different ways to build and install APK: one with --deviceId provided and one without. This PR unifies that process.

What has changed

Moved all methods related to APK build and install to buildAndInstallApk.ts (including utility functions).
Removed old and unused code.
Exported two new functions :
- buildApk - builds APK using provided variants.
- installApk - checks if APK has been build for specified variant. If it is, use adb to install. Otherwise use gradle's install* task to build and install.

To Do:

cleanup
tests

Test Plan:

Green CI.

thymikee · 2020-03-19T10:00:23Z

How's it going, do you need any help here?

krizzu · 2020-03-19T10:37:44Z

Hey, working on Jest tests and manual testing too - should be here soonish

krizzu · 2020-03-23T16:28:32Z

This one is ready for some reviews, thanks!

krizzu · 2020-04-20T07:46:00Z

@thymikee @Esemesek
Any idea why those doctor e2e tests fails?

thymikee · 2020-04-20T08:05:14Z

Azure fails with "EPERM: operation not permitted, mkdir 'D:'" when we try to create a temporary directory for testing, maybe something changed there? Sounds like Azure changing something, would be good to verify this in other PRs

Esemesek · 2020-04-20T13:32:01Z

I think this test fails randomly. We consider Windows failures as non-blocking since most of them are just flakiness in the Azure environment.

grabbou · 2020-05-26T20:47:11Z

Do you feel like giving this one a go @thymikee @Esemesek before shipping? Since it's ready and failures are non-related, I'd love to have a final approval from your side.

grabbou · 2020-09-17T13:55:10Z

Since this code is ready to go and this is our second attempt and rewriting this relatively major part of run-android, I am going to take it over and do the last round of testing myself.

I am hoping we can ship it next week, it should resolve some really annoying issues.

driiftkiing · 2021-06-30T11:01:45Z

@thymikee: i have rebased the branch of this pr with the master into this branch https://github.com/tokyodrift1993/react-native-community-cli/tree/feature/buildApkFixes

thymikee · 2021-06-30T12:42:31Z

@driiftkiing can you send a PR amending this one? :)

driiftkiing · 2021-06-30T12:53:18Z

@driiftkiing can you send a PR amending this one? :)

just creating a new one? or something else?

thymikee · 2021-06-30T14:54:38Z

Yup, a new one. Unless @krizzu is still interested in pursuing this, but let's assume he's not and make sure to attribute him for the work done when merging

krizzu · 2021-06-30T17:21:14Z

@driiftkiing @thymikee
Been a while 🤖
I just rebased the code, tests are passing. I'm yet to test this, making sure that it works properly.

krizzu · 2021-06-30T19:33:52Z

Ran some tests on custom android project, trying different configuration of build variants (with and without flavors) and it works.
Would love to have someone else do the sanity check as well 🙏

grabbou · 2021-07-06T13:06:05Z

Thanks @krizzu, I am going to do another pass at it this week and ship it!

driiftkiing · 2021-07-07T12:02:44Z

I will do also some tests, if i got the time

thymikee · 2021-07-12T12:58:58Z

Thanks for the review @andriytsaryov. @grabbou I guess we can finally go ahead and merge it

grabbou · 2021-07-15T14:36:44Z

Yes, that's on my todo list for tomorrow. When ready, I will create a new release.

grabbou · 2021-07-16T13:23:32Z

+  await buildApk(args, gradlew, androidProject);
+  await installApk(args, gradlew, adbPath, devices, androidProject);
+
  try {


I believe this code is already moved out to buildApk and installApk respectively, e.g. args.port and createInstallError. I am going to go ahead and remove it.

pas256 · 2022-02-04T05:28:37Z

I'd love to be able to run

npx react-native run-android --variant=developmentDebug --deviceId 931X1X9JW

and have it work. This PR seems to solve that. Anything holding this up getting merged in?

grabbou · 2022-02-04T16:07:28Z

No, @pas256, this PR will be pulled in soon, once we merge a PR removing link and unlink.

driiftkiing · 2022-02-07T11:19:25Z

if anyone is interested to use this PR until it is merged:

created patch: https://gist.github.com/driiftkiing/09f3bd7bb125e6436a5caba7834f3a99

used for yarn v3
can be used like:

diff --git a/package.json b/package.json
--- a/package.json
+++ b/package.json
   "resolutions": {
+    "@react-native-community/cli-platform-android": "patch:@react-native-community/cli-platform-android@npm:6.3.0#.yarn/patches/@react-native-community-cli-platform-android-npm-6.3.0-1b9d17ef3a",
   },

source: https://github.com/tokyodrift1993/react-native-community-cli/tree/krizzu/buildApkFixes--merged-v6.3.0
merged v6.3.0
(fixed lint & tests)
should be compatible with react-native@0.67.2

command to run:

yarn react-native run-android --variant=developmentDebug

github-actions · 2022-11-28T03:32:11Z

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

TMisiukiewicz · 2022-11-28T12:34:20Z

#1739 closes this one

krizzu · 2022-12-06T15:11:44Z

🫡

krizzu requested review from Esemesek, grabbou and thymikee as code owners March 17, 2020 11:32

grabbou reviewed Mar 20, 2020

View reviewed changes

Comment thread packages/platform-android/src/commands/runAndroid/index.ts

krizzu changed the title ~~[WIP] refactor: unify APK building and installing process~~ refactor: unify APK building and installing process Mar 22, 2020

thymikee reviewed Mar 23, 2020

View reviewed changes

Comment thread packages/platform-android/src/commands/runAndroid/__tests__/buildAndInstallApk.test.ts

thymikee reviewed Mar 23, 2020

View reviewed changes

Comment thread packages/platform-android/src/commands/runAndroid/buildAndInstallApk.ts Outdated

krizzu force-pushed the buildApkFixes branch from a516d48 to 15d590a Compare March 24, 2020 11:04

krizzu force-pushed the buildApkFixes branch 2 times, most recently from 648389a to acf762a Compare April 17, 2020 17:00

grabbou self-assigned this Sep 17, 2020

grabbou added the taken label Sep 17, 2020

thymikee mentioned this pull request Mar 12, 2021

run-android on real device using custom flavors #1373

Closed

refactor: unify apk build and install process

1f5e839

krizzu force-pushed the buildApkFixes branch from acf762a to 1f5e839 Compare June 30, 2021 17:19

andrewtsar0w approved these changes Jul 7, 2021

View reviewed changes

Merge branch 'master' into buildApkFixes

d3cd850

grabbou approved these changes Jul 16, 2021

View reviewed changes

grabbou reviewed Jul 16, 2021

View reviewed changes

Update runOnAllDevices.ts

be0e2b7

adamTrz mentioned this pull request Nov 9, 2022

feat: build-android command #1739

Merged

5 tasks

github-actions Bot added the stale label Nov 28, 2022

github-actions Bot removed the stale label Nov 29, 2022

adamTrz closed this in #1739 Dec 6, 2022

krizzu deleted the buildApkFixes branch December 6, 2022 15:10

Conversation

krizzu commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

What has changed

To Do:

Test Plan:

Uh oh!

thymikee commented Mar 19, 2020

Uh oh!

krizzu commented Mar 19, 2020

Uh oh!

Uh oh!

krizzu commented Mar 23, 2020

Uh oh!

Uh oh!

Uh oh!

krizzu commented Apr 20, 2020

Uh oh!

thymikee commented Apr 20, 2020

Uh oh!

Esemesek commented Apr 20, 2020

Uh oh!

grabbou commented May 26, 2020

Uh oh!

grabbou commented Sep 17, 2020

Uh oh!

driiftkiing commented Jun 30, 2021

Uh oh!

thymikee commented Jun 30, 2021

Uh oh!

driiftkiing commented Jun 30, 2021

Uh oh!

thymikee commented Jun 30, 2021

Uh oh!

krizzu commented Jun 30, 2021

Uh oh!

krizzu commented Jun 30, 2021

Uh oh!

grabbou commented Jul 6, 2021

Uh oh!

driiftkiing commented Jul 7, 2021

Uh oh!

thymikee commented Jul 12, 2021

Uh oh!

grabbou commented Jul 15, 2021

Uh oh!

grabbou Jul 16, 2021

Choose a reason for hiding this comment

Uh oh!

pas256 commented Feb 4, 2022

Uh oh!

grabbou commented Feb 4, 2022

Uh oh!

driiftkiing commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 28, 2022

Uh oh!

TMisiukiewicz commented Nov 28, 2022

Uh oh!

krizzu commented Dec 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

krizzu commented Mar 17, 2020 •

edited

Loading

driiftkiing commented Feb 7, 2022 •

edited

Loading