chore: Update cli-plugin-metro to use external Metro types#1874
Merged
Conversation
huntie
force-pushed
the
rn-metro-config
branch
2 times, most recently
from
40e166a to
803f49e
Compare
huntie
force-pushed
the
rn-metro-config
branch
2 times, most recently
from
cd7bb5c to
28fe385
Compare
thymikee
reviewed
Mar 16, 2023
thymikee
approved these changes
Mar 16, 2023
thymikee
left a comment
thymikee
left a comment
Member
There was a problem hiding this comment.
Thanks! Other than that one comment it LGTM
adamTrz
approved these changes
Mar 17, 2023
huntie
commented
Mar 17, 2023
Collaborator
Author
|
Thanks for feedback! 🙌🏻 Ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes internally defined types and some
// @ts-ignorecomments incli-plugin-metroby using the DefinitelyTyped packages (recently updated in DefinitelyTyped/DefinitelyTyped#64735) at0.76. This will make breaking API changes in Metro easier to identify in future.No anticipated breaking changes.
Depends on:
Test Plan: