fix: Pin exact versions of RN CLI dependencies#1893
Merged
Conversation
huntie
force-pushed
the
rfc-version-pinning
branch
from
d5900a0 to
41ac9c7
Compare
thymikee
reviewed
Mar 28, 2023
thymikee
reviewed
Mar 28, 2023
thymikee
left a comment
thymikee
left a comment
Member
There was a problem hiding this comment.
Yeah, let's do it to be compatible with how RN consumes the CLI
huntie
changed the title
huntie
force-pushed
the
rfc-version-pinning
branch
from
41ac9c7 to
acf7c57
Compare
thymikee
approved these changes
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In the React Native repo, we are pinning all versions of
@react-native-community/clidependencies in order to simplify the possible dependency trees of the framework.Unfortunately, we recently had our version of
@react-native-community/clipinned to"11.0.0-alpha.2", thinking this was sufficient. However (in contexts without a lockfile, such as the RN template) cross-dependencies of packages in this repo using caret versions (e.g.^11.0.0) meant that adjacent packages could pre-emptively pull in new versions. Therefore, on Friday we unexpectedly received a bump of@react-native-community/cli-plugin-metroat11.0.0in our0.72-rcbranch, which broke the RC (andmainbranch CI).Relates to: