fix: install pods on ios-commands with New Arch

[TMisiukiewicz]

Summary:

Coming from #2091. Currently, when installed pods with New Architecture manually, added new package and used run-ios, it installed pods with old Architecture again. This change checks if the New Architecture is enabled and installs it with/without a flag.

Test Plan:

1. Init new project and install pods during the init
2. Add a library containing native code e.g. react-native-gesture-handler
3. Run run-ios and verify it installed pods and ran the app
4. Go to ios folder and install pods with New Arch manually, RCT_NEW_ARCH_ENABLED=1 pod install
5. Add another library, e.g. react-native-reanimated
6. Run run-ios and verify pods are being installed with a with New Architecture message
7. When app is running, verify fabric: true is visible in Metro console

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[thymikee]

@cipolleschi is this fine if we use that to detect new arch?

[cipolleschi]

yes, this should be enough.

[thymikee]

@TMisiukiewicz please rebase and merge? :)

[szymonrybczak]

We have the same logic in doctor command:

cli/packages/cli-doctor/src/commands/info.ts

Lines 55 to 64 in 36d00ea

	const project = await readFile(
	path.join(
	ctx.project.ios.sourceDir,
	'/Pods/Pods.xcodeproj/project.pbxproj',
	),
	);
	platforms.iOS.newArchEnabled = project.includes(
	'-DRCT_NEW_ARCH_ENABLED=1',
	);

mind using this function also there - so we won't have in two places same code? 🙏

[TMisiukiewicz]

it's already here:

cli/packages/cli-doctor/src/commands/info.ts

Line 56 in ef7a66a

const isNewArchitecture = await getArchitecture(

[TMisiukiewicz]

@szymonrybczak to resolve conflicts i moved iosFolderPath to installPods options object, would you mind double-check if it's fine?

[szymonrybczak]

Hm, I'm wondering should we add here info about flags that we added 🤔

[szymonrybczak]

LGTM 🙌

[ManasGuptaSprinklr]

@TMisiukiewicz @szymonrybczak @cortinico , I am facing an issue. When we run the command run-ios, it uses a new arch-enabled flag via the getArchitecture function, which references Pods/Pods.xcodeproj/project.pbxproj. However, if someone runs the command pod-deintegrate, then running the run-ios command will always use the legacy architecture (fallback if file not found). Can you please check this?

RCT_NEW_ARCH_ENABLED=1 pod install
This command can be run before, but it is giving a deprecation message on React Native 0.79. It is suggested to run run-ios directly.