Support video option on Android

[namnm]

Bug report

• I've checked the example to reproduce the issue.

• Reproduced on:

• Android

Description

Look like ConnectionService support video call, can we add support for it in this RN module?

[danjenkins]

I've got partial support in a branch of you're interested

…

On Mon, 4 May 2020, 02:49 Nam Nguyen, ***@***.***> wrote: Bug report - I've checked the example <https://github.com/react-native-webrtc/react-native-callkeep/tree/master/example> to reproduce the issue. - Reproduced on: - Android Description Look like ConnectionService support video call, can we add support for it in this RN module? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#193>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB3LLPIJBAQ3Y2TDB4LMM3RPYNJNANCNFSM4MYMKKHQ> .

[namnm]

@danjenkins Which branch you mean?

[danjenkins]

It's on the nimbleape GitHub org - currently on my phone will find it once I'm at my desk for you

[namnm]

Thanks. I think this one: https://github.com/nimbleape/react-native-callkeep-1/tree/allow-non-numbers-and-android-video

I'll take a look. Although video option is not a critical requirement for us now, but soon or later we will need it.

[sboily]

@danjenkins how can we help you to finish this branch? We are currently working to integrate video calls in our application and we will work to integrate video on callkeep, but it will be probably better to work together to don't reinvented the wheel ;-) CC @manuquentin

[danjenkins]

@sboily I could move the branch over to this repo for starters?

For me, I think the main part thats missing is the VideoProvider class ? I think....

https://developer.android.com/reference/android/telecom/Connection.VideoProvider

But more than happy to move that branch over, or I can give you guys access into the nimble ape repo.

[sboily]

@danjenkins yes i haven't any objections to do that. If it help people to contribute it, no worry.

[danjenkins]

@sboily the code is now in branch react-native-webrtc/react-native-callkeep#allow-non-numbers-and-android-video , however it currently does multiple things... (it was a branch for a client that I'm not done with) - firstly - disables hold support (we need to be able to enable/disable this thorugh config options), enables support for the sip scheme, and does enough work for video support to work but needs extra work!

[sboily]

@danjenkins can you make this branch as a PR to discuss directly in the PR. And can you give us more information about the extra work needs you think?

[sboily]

iOS video support #181

[alebagran]

Hi, is there any news on video call implementation?

[luxiliu]

Hi @danjenkins , apart from VideoProvider, using own ui to display call also needs to be considered.

[danjenkins]

@luxiliu there's already a feature request for it in the issues tracker. If you want to build the code and contribute it, the collaborators will get to it when any of us get time. Building real time Comms apps on native is incredibly complex and we all have day jobs. None of us build things and keep them private, they immediately go public. Have the common decency to read through the issues and see whats already been asked for and stop wasting people's time. If you had you'd have seen that someone has already built most of this functionality bit hasn't got the time to integrate it back into this repo right now - if you need this functionality then you could use the form that's been listed in an issue for over 6 months.

Think before commenting. Please.

[danjenkins]

Hi, is there any news on video call implementation?

Nope... Otherwise there would have been a comment or a PR closing this......

Seriously, please start considering collaborators have lives and jobs before commenting asking for updates when if there was..... They would have already been posted here.

[luxiliu]

@danjenkins , I think you misunderstood what I meant. I was not pushing you for a pr or a fix. I was just saying it is also an option, which need to consider just incase you're developing it.

Think before replying. Please.