Allow non numbers and android video#216
Conversation
|
|
||
| PhoneAccount.Builder builder = new PhoneAccount.Builder(handle, appName) | ||
| .setCapabilities(PhoneAccount.CAPABILITY_CALL_PROVIDER); | ||
| .addSupportedUriScheme(PhoneAccount.SCHEME_SIP) |
There was a problem hiding this comment.
Adding this parameter make the startCall method displaying ConnectionService for another call account :
And when I remove it :
Is there a way to enable SCHEME_SIP for a call account ? Or enable it only if we want to display SIP scheme ?
There was a problem hiding this comment.
🤷 lol. Sorry! Like I said... I kinda made this branch for a specific need with a specific client and was going to put the work in to make it generic afterwards. Its not just this change, i removed the ability to place a call on hold for example.... because ultimately that should be something we pass in as a flag
|
Can we close this PR as it seem to be continued in #237 ? |
|
that PR adds into this one... this one should just be a draft - and was
only made to enable conversation - its 100% not ready to be merged - theres
a lot in here that shouldnt be
…On Mon, Jul 20, 2020 at 1:41 PM Emmanuel Quentin ***@***.***> wrote:
Can we close this PR as it seem to be continued in #237
<#237> ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB3LLPC2P7TMEGGALEYZBLR4Q3QPANCNFSM4NZWMDQQ>
.
|
|
Hello @danjenkins, i made a PR for a first works on video support. Check #251. I don't understand why we need to keep this PR. What is the main target of this PR. The #237 is to supported self managed capability. Can we rename this PR to reflect what we want to achieve? Thank you. |
|
I only made this draft PR because you and @manuquentin asked me to from what I remember :) As a way of looking at the code and progressing it - it was never designed to be merged because theres multiple changes in here. If you've added video support for android in another PR then we can close this one! I'll end up making another to support non numbers (sip uris) when I get some time to make the changes work properly! |
|
Yes yes i remember ;), thank you for this first work! A new PR with to support non numbers (sip uris) will be nice. Thank you! |
HarshitPadalia
left a comment
HarshitPadalia
left a comment
There was a problem hiding this comment.
Hello is there any plan to merge this to main branch?
|
or let me know you are facing any issues. so I can help to shoutout any problems you. are facing |
4 participants
This branch needs updating in numerous ways and split out
Making a draft PR to discuss those things