refactor: dispatch back instead of reset if we determine it's a simple pop#13077
Open
refactor: dispatch back instead of reset if we determine it's a simple pop#13077
Conversation
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13077 +/- ##
==========================================
+ Coverage 72.24% 72.32% +0.07%
==========================================
Files 238 238
Lines 8391 8425 +34
Branches 3480 3498 +18
==========================================
+ Hits 6062 6093 +31
- Misses 2274 2278 +4
+ Partials 55 54 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
satya164
force-pushed
the
@satya164/linking-pop
branch
2 times, most recently
from
07aaecf to
d62ae0d
Compare
satya164
force-pushed
the
@satya164/linking-pop
branch
from
d62ae0d to
edc72ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this changes browser history handling to dispatch a
GO_BACKaction instead ofRESETwhen we determine that it's a simple pop in history. this makes it possible to preserve any other state updates made since the last state was tracked.