Upgrade address to fix urls.lanUrlForConfig not getting defined#12407
Upgrade address to fix urls.lanUrlForConfig not getting defined#12407joey-laminar wants to merge 1 commit into
Conversation
|
Hi @joey-laminar! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
When using node 18 the old
addresslibrary is unable to resolve ip addresses. This causes running a local server to fail withsimilarly to the issue reported in #11762
The latest version of
addressfixes this issue.This will also relieve part of the pain that #11877 tries to solve (although that PR is still necessary in case the address resolution fails for other reasons).