Forked react-scripts should retain the binary name#754
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
ghost
added
the
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| new RegExp(ownPackageName + ' (\\w+)', 'g'), | ||
| 'node scripts/$1.js' | ||
| ); | ||
| new RegExp(/react-scripts (\w+)/g, 'node scripts/$1.js' |
There was a problem hiding this comment.
I think new RegExp( is unnecessary here since you already use the implicit regex syntax by wrapping it with /s. The second argument ('node scripts/$1.js) should be the argument to replace, not to RegExp constructor. Let me know if I’m missing something!
| new RegExp(ownPackageName + ' (\\w+)', 'g'), | ||
| 'node scripts/$1.js' | ||
| .replace(/react-scripts (\w+)/g, 'node scripts/$1.js' | ||
| ); |
There was a problem hiding this comment.
Style nit: since the line is shorter now, let's bring this closing paren and the semicolon to the end of the previous line?
|
This looks right to me. Let's wait for Travis and then merge. Thanks! |
|
Thanks again! 👍 |
…react-app # By Ville Immonen (2) and others # Via Dan Abramov * 'master' of https://github.com/facebookincubator/create-react-app: added link to better visualizing tool (react#764) Fix the right and bottom padding of the error overlay (react#758) Remove the `.` at the end of the init message (react#760) Bump recursive-readdir (react#756) Forked react-scripts should retain the binary name (react#754) Mention the npm bug in migration instructions
* Forked react-scripts should retain the binary name * Forked react-scripts should retain the binary name -- fixed issue with regex * Forked react-scripts should retain the binary name -- fixed style nit
…react-app # By Ville Immonen (2) and others # Via Dan Abramov * 'master' of https://github.com/facebookincubator/create-react-app: added link to better visualizing tool (react#764) Fix the right and bottom padding of the error overlay (react#758) Remove the `.` at the end of the init message (react#760) Bump recursive-readdir (react#756) Forked react-scripts should retain the binary name (react#754) Mention the npm bug in migration instructions
2 participants
Fixes #753