Skip to content

Fix Travis CI config in template README.md#910

Merged
fson merged 1 commit into
react:masterfrom
scholtzm:fix-travis-config-in-template-readme
Oct 17, 2016
Merged

Fix Travis CI config in template README.md#910
fson merged 1 commit into
react:masterfrom
scholtzm:fix-travis-config-in-template-readme

Conversation

@scholtzm
Copy link
Copy Markdown
Contributor

  1. Added : after script.
  2. Added extra indent as per the example here.

The config now passes YAML validation (was broken before) and I'm using it on Travis CI myself.

@facebook-github-bot
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@fson
Copy link
Copy Markdown
Contributor

fson commented Oct 17, 2016

Thanks!

@fson fson merged commit e4e86cd into react:master Oct 17, 2016
@scholtzm scholtzm deleted the fix-travis-config-in-template-readme branch October 17, 2016 20:17
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
@lock lock Bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants