Skip to content

Allow configuring the webpackHotDevClient with a url #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rzane wants to merge 1 commit into from
Closed

Allow configuring the webpackHotDevClient with a url #965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/react-dev-utils/webpackHotDevClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@ var formatWebpackMessages = require('./formatWebpackMessages');
var Entities = require('html-entities').AllHtmlEntities;
var entities = new Entities();

var urlParts;
var query = __resourceQuery; // eslint-disable-line

if (typeof query === "string" && query) {
urlParts = url.parse(query.substr(1));
} else {
urlParts = window.location;
}

// Color scheme inspired by https://github.com/glenjamin/webpack-hot-middleware
var colors = {
reset: ['transparent', 'transparent'],
Expand Down Expand Up @@ -138,9 +147,9 @@ function destroyErrorOverlay() {

// Connect to WebpackDevServer via a socket.
var connection = new SockJS(url.format({
protocol: window.location.protocol,
hostname: window.location.hostname,
port: window.location.port,
protocol: urlParts.protocol,
hostname: urlParts.hostname,
port: urlParts.port,
// Hardcoded in WebpackDevServer
pathname: '/sockjs-node'
}));
Expand Down