bug: metro-config doesn't have types in npm package

[stevezhu]

It seems that metro-config doesn't have types anymore in the npm package? Probably related to a7cc922.

Issue starts on metro-config v0.83.4.

• Npm packaged files can be seen here missing types (v0.84.1 is the latest version as of writing):
  https://www.npmjs.com/package/metro-config/v/0.84.1?activeTab=code
• Compare to v0.83.3 which seems to be the last version before the types change:
  https://www.npmjs.com/package/metro-config/v/0.83.3?activeTab=code

I would assume this could also be the case for other packages with the types update (maybe related to #1648) or some of the packages might not have types exported to begin with.
Eg. https://www.npmjs.com/package/metro-runtime/v/0.84.1?activeTab=code

@robhogan

[stevezhu]

Maybe marginally related but is #1491 fixed by these changes?

[robhogan]

Wow, thanks for reporting this @stevezhu - a lot of work has gone into producing accurate TS types recently and it seems like we've simultaneously broken actually shipping them 🤦‍♂️

I think this is the blame commit in this case: #1627

tinyglobby produces relative paths, which broke some string replacement and meant the TS files weren't copied into the build directory.

#1662 should fix, and we'll backport it. Thanks again.

[stevezhu]

Amazing, thanks for the quick turnaround and the work on the new types!

[robhogan]

Fixed in https://github.com/facebook/metro/releases/tag/v0.83.5 / https://github.com/facebook/metro/releases/tag/v0.84.2

And yep, now (almost*) all APIs (even under (/private/) should have accurate, auto generated TS types.

(*A few specific files that need to use Common JS syntax, mostly workers and dependencies, have manual types, these are all private APIs anyway.)

Thanks again!