Skip to content

Create 0.62 versioned documentation#1775

Closed
kelset wants to merge 3 commits into
masterfrom
chore/062-cut
Closed

Create 0.62 versioned documentation#1775
kelset wants to merge 3 commits into
masterfrom
chore/062-cut

Conversation

@kelset

@kelset kelset commented Mar 23, 2020

Copy link
Copy Markdown
Contributor

This is just a PR to add the versioned version of the docs ahead of the 0.62.0 release coming soon ™️

Once this is merged, another PR will need to be created to then move the website to show 0.62 as default, as done in the past like 5a0f9d2

@react-native-bot

react-native-bot commented Mar 23, 2020

Copy link
Copy Markdown

Deploy preview for react-native ready!

Built with commit bea5a13

https://deploy-preview-1775--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@Simek

Simek commented Mar 23, 2020

Copy link
Copy Markdown
Collaborator

I think that 0.62 should be created after #1771 merge.

Also as far as I know @rachelnabors have a plan/checklist ready for this new release which include some unconventional steps (like regenerating 0.61 before creating 0.62).

@kelset

kelset commented Mar 23, 2020

Copy link
Copy Markdown
Contributor Author

hey Simek thanks for the info, I didn't know anything of that sort 😓

@thymikee

Copy link
Copy Markdown
Contributor

@Simek updating prettier config doesn't seem like a real blocker, right? As soon as there are conflicts, revoking styling changes and running prettier once again is automatic and doesn't involve manual work, so it could land anytime.

@Simek

Simek commented Mar 24, 2020

Copy link
Copy Markdown
Collaborator

@thackley I never said it's blocker but it saves additional, redundant work in future and I assume that this PR will land in the master shortly.

But as I said before community gathered around react-native-website has been discussing about upcoming new version and the way how to handle this operation properly for the few months (mainly here: #1579) and it will be unfair to discard this work. So in the light of the arguments presented here I see no reason to rush 0.62 generation, but I'm not here to decide.

I hope @rachelnabors will engage in this conversation, explain everything and post the migration plan/checklist soon.

@kelset

kelset commented Mar 24, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the context @Simek 👍 I created the PR because we are getting closer to release 0.62.0 and I got told that everything was 'ok' on the website side so I proceeded with creating this pr.

I've pinged Rachel in the discord and hopefully she'll let us know more soon :)

@nearestnabors

Copy link
Copy Markdown
Contributor

@kelset #1771's Prettier changes are not necessary for 0.62's docs. They change a lot of files and I'd like them to spend a little more time in review for that.

There is a sidebar change that could be nice to get in there that @Simek reminded me about: putting deprecation warnings on component and APIs in 0.61 while removing them in 0.62 from the sidebar. But we need a PR for it.

@kelset

kelset commented Mar 24, 2020

Copy link
Copy Markdown
Contributor Author

ok, then can you approve this PR so that we can proceed with merging? :)

@nearestnabors

Copy link
Copy Markdown
Contributor

I patched up 0.61's sidebars with this PR: #1779 Please re-generate!

@kelset

kelset commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

allright, closing this and recreating!

@kelset kelset closed this Mar 25, 2020
@kelset

kelset commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

btw @rachelnabors it looks like I'm not allowed to remove this branch from origin 😓

@kelset

kelset commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

New PR with the new cut -> #1782

@yungsters yungsters deleted the chore/062-cut branch September 1, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants