Fix Platform.OS reference#1812
Closed
pfertyk wants to merge 1 commit into
Closed
Conversation
Contributor
|
maintainers: please note this fix (and more fixes) are included in #1803 |
Contributor
Author
|
I didn't know there is another PR for the same fix, thanks for the link ;) |
Collaborator
Contributor
Author
|
@Simek great news, thanks for letting me know ;) Do you know when will the documentation be updated? The typo is still there: https://reactnative.dev/docs/keyboardavoidingview |
Collaborator
Contributor
|
Thanks for submitting! I know we couldn't accept this one, but it would be great if you could edit 0.62's docs to include the same change, @pfertyk! |
Contributor
Author
|
Thank for the feedback @rachelnabors , I will send a new PR soon ;) |
Contributor
Author
|
@rachelnabors PR submitted: #1826, please correct me if that was the wrong file to edit for 0.62 ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference to
Platform.Osis incorrect, it should bePlatform.OS. It is a small one, but it costed me some time (I thought thatKeyboardAvoidingViewis not working, but it just used a wrong setting for iOS, because of this typo ;) ).