Skip to content

Fix scrolling bug in side nav#2098

Merged
Simek merged 1 commit into
react:masterfrom
davidflack:desktop-sidenav-scroll-fix
Jul 24, 2020
Merged

Fix scrolling bug in side nav#2098
Simek merged 1 commit into
react:masterfrom
davidflack:desktop-sidenav-scroll-fix

Conversation

@davidflack

Copy link
Copy Markdown
Contributor

Hello! Currently, when viewing the documentation in a desktop browser, if the right side navigation bar has more items than can fit within the page's height, there is no way to view these items. For example, users cannot navigate through all of the props of large components such as View or FlatList by using the right navigation bar. (https://reactnative.dev/docs/flatlist.html)

This pull requests adds a vertical scroll bar when there are more right nav items than can fit the screen. Otherwise, there is no scroll bar.

@facebook-github-bot

Copy link
Copy Markdown

Hi @Zooheck!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-bot

Copy link
Copy Markdown

Deploy preview for react-native ready!

Built with commit 75f3c1a

https://deploy-preview-2098--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@Simek Simek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Zooheck, thank you so much for great description of the problem and the fix! 👍

I have introduced this issue by mistake in the latest platforms labels update, my bad, sorry!

@Simek Simek merged commit 6079803 into react:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants