Skip to content

update RefreshControl page, fix minor platform labels display issues#2100

Merged
nearestnabors merged 1 commit into
react:masterfrom
Simek:update-refreshcontrol-page
Jul 29, 2020
Merged

update RefreshControl page, fix minor platform labels display issues#2100
nearestnabors merged 1 commit into
react:masterfrom
Simek:update-refreshcontrol-page

Conversation

@Simek

@Simek Simek commented Jul 26, 2020

Copy link
Copy Markdown
Collaborator

This PR updates the RefreshControl component page and introduces the following changes:

  • platform and required labels
  • example cleanup
  • defined defaults
  • section for RefreshLayoutConsts.SIZE with additional information
  • minor formatting tweaks

Source for the changes: https://github.com/facebook/react-native/tree/master/Libraries/Components/RefreshControl

In addition to the page update the following PR sizes two minor display issues with the platform labels. One related to latest scroll fix and second related to the multiple platforms for one property.

Preview

Annotation 2020-07-26 154432

@react-native-bot

Copy link
Copy Markdown

Deploy preview for react-native ready!

Built with commit 48e494c

https://deploy-preview-2100--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

1 similar comment
@react-native-bot

Copy link
Copy Markdown

Deploy preview for react-native ready!

Built with commit 48e494c

https://deploy-preview-2100--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@nearestnabors nearestnabors left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sm_thanks

Eeee, love it!

@nearestnabors nearestnabors merged commit 0194065 into react:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants