Skip to content

[android] [native-modules-android.md] consistent code for adding package to MainApplication.kt #4047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChronSyn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[android] [native-modules-android.md] consistent code for adding package to MainApplication.kt #4047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a055d
Update native-modules-android.md
ChronSyn Mar 8, 2024
051c026
Consistent docs on android native modules (MainApplication.kt changes)
ChronSyn Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions docs/native-components-android.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,9 +795,12 @@ public class MyPackage implements ReactPackage {
<TabItem value="kotlin">

```kotlin title="MainApplication.kt"
override fun getPackages() = PackageList(this).packages.apply {
add(MyPackage())
}
override fun getPackages(): List<ReactPackage> =
PackageList(this).packages.apply {
// Packages that cannot be autolinked yet can be added manually here, for example:
// add(MyReactNativePackage());
add(MyAppPackage())
}
```

</TabItem>
Expand Down
2 changes: 1 addition & 1 deletion docs/native-modules-android.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ Locate ReactNativeHost’s `getPackages()` method and add your package to the pa
override fun getPackages(): List<ReactPackage> =
PackageList(this).packages.apply {
// Packages that cannot be autolinked yet can be added manually here, for example:
// packages.add(new MyReactNativePackage());
// add(MyReactNativePackage());
add(MyAppPackage())
}
```
Expand Down