[Android][StyleSheet] Unitless string used as value causes app crash

[Simek]

Description

Refs react/react-native-website#1834.

Currently when unitless string is used as property value (where number or string with unit can be used) Android application crashes, while on iOS value is converted to the number and on the web invalid property is omitted app works correctly.

React Native version:

• Expo 37.0.0
• React Native 0.62.2

Steps To Reproduce

Provide a detailed list of steps that reproduce the issue.

1. Use unitless string as property value (where number or string with unit can be used).

Expected Results

Property with invalid value should be converted like on iOS or omitted like on the web. Also Android
app should not crash.

As a feature request, it could be nice to convert that value to number and print console warning in DEV mode.

Snack, code example, screenshot, or link to a repository:

• https://snack.expo.io/@simek/unitless-string-crash-on-android

[elicwhite]

In Dev I see the crash on android, and a redbox on iOS. I haven't figured out what the prod experience is yet. Are you saying that in prod iOS continues and Android crashes?

In Dev:

Android:

04-16 11:46:29.882 12338 12402 E ReactNative: java.lang.IllegalArgumentException: Unknown value: 10
04-16 11:46:29.882 12338 12402 E ReactNative: 	at com.facebook.react.uimanager.LayoutShadowNode$MutableYogaValue.setFromDynamic(LayoutShadowNode.java:63)
04-16 11:46:29.882 12338 12402 E ReactNative: 	at com.facebook.react.uimanager.LayoutShadowNode.setPaddings(LayoutShadowNode.java:688)

[Simek]

I'm just a "re-reporter", I can only confirm that expo example crashes on Android (in web player and on the device), when on iOS in both cases app is running. I don't have physical Android device right now to test this out more, but before I reported that issue I got a confirmation that it also crashes Android without expo. I have updated the issue to make it more clear.

[elicwhite]

In Fabric (at least on Android) the behavior is different as well. padding: "100" is treated as the number padding: 100 and does not crash.

[elicwhite]

I tried this out on 0.60 and was able to get a redbox on Android.

[Simek]

Using unitless string as fontSize value on iOS produces different RedBox in DEV mode than you posted in first reply:

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[Simek]

🤖

[github-actions]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.