Skip to content

fix examaple TabBarIOSExample bug; show click num when user click second & third tabbar#1522

Closed
vczero wants to merge 1 commit into
react:masterfrom
vczero:master
Closed

fix examaple TabBarIOSExample bug; show click num when user click second & third tabbar#1522
vczero wants to merge 1 commit into
react:masterfrom
vczero:master

Conversation

@vczero

@vczero vczero commented Jun 5, 2015

Copy link
Copy Markdown

No description provided.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2015
@sahrens

sahrens commented Jun 13, 2015

Copy link
Copy Markdown
Contributor

This seems reasonable, but can you rebase and make sure tests are passing?

@sahrens sahrens self-assigned this Jun 13, 2015
@sahrens

sahrens commented Jun 13, 2015

Copy link
Copy Markdown
Contributor

@facebook-github-bot import

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/894583160580151/int_phab to review.

@sahrens

sahrens commented Jun 15, 2015

Copy link
Copy Markdown
Contributor

Can you rebase and re-record the snapshot tests to get the travis build to pass?

@vczero

vczero commented Jun 16, 2015

Copy link
Copy Markdown
Author

@sahrens Can you rebase and re-record the snapshot tests to get the travis build to pass?--this is for @facebook-github-bot? if not be, how can I do? Thank you ~

@sahrens

sahrens commented Jun 16, 2015

Copy link
Copy Markdown
Contributor

The bot can't help here - you need to re-record for any change that will affect the snapshot tests. Follow the instructions in the docs here, update your PR, and make sure your Travis build passes and then we'll merge it in:

https://github.com/facebook/react-native/blob/master/docs/Testing.md#running-tests-and-contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants