Skip to content

fix checkbox casting crash in old android versions#23281

Closed
vonovak wants to merge 1 commit into
react:masterfrom
vonovak:22885
Closed

fix checkbox casting crash in old android versions#23281
vonovak wants to merge 1 commit into
react:masterfrom
vonovak:22885

Conversation

@vonovak

@vonovak vonovak commented Feb 3, 2019

Copy link
Copy Markdown
Contributor

Summary

fixes casting on older android versions reported in #22885

Changelog

[Android] [Fixed] - fix casting crash in android checkbox

Test Plan

run the RNTester app on android 4.4 and tick a checkbox

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2019
@vonovak vonovak changed the title fix casting crash in #22885 fix checkbox casting crash in old android versions Feb 3, 2019
@vonovak vonovak mentioned this pull request Feb 3, 2019
3 tasks

@cpojer cpojer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 4, 2019

@facebook-github-bot facebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot

Copy link
Copy Markdown
Collaborator

@vonovak merged commit 58437cd into facebook:master.

@react react locked as resolved and limited conversation to collaborators Feb 4, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 4, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants