Skip to content

[fix] change Yoga module name capitalisation in podspec to fix build issue #34058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kelset wants to merge 1 commit into from
Closed

[fix] change Yoga module name capitalisation in podspec to fix build issue #34058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ReactCommon/yoga/Yoga.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Pod::Spec.new do |spec|
spec.authors = 'Facebook'
spec.source = source

spec.module_name = 'yoga'
spec.module_name = 'Yoga'
spec.header_dir = 'yoga'

@mikehardy mikehardy Jun 23, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no special knowledge here but it seems suspicious to have header_dir lowercase while module name is upper? Makes the spidey-sense tingle but it may actually be lower for the files 🤷

@kelset kelset Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah tbh I was wondering if we should change both

@kelset kelset Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but wanted to get CI to run first, and get Riccardo's take ;)

@cortinico cortinico Jun 23, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is red btw, and it seems related to this change

spec.requires_arc = false
spec.pod_target_xcconfig = {
Expand Down