Skip to content

[fix] Update 0.72-stable with rncore podspec fix#36588

Closed
hoxyq wants to merge 1 commit into
react:0.72-stablefrom
hoxyq:hoxyq/cherry-pick-rncore-podspec-fix
Closed

[fix] Update 0.72-stable with rncore podspec fix#36588
hoxyq wants to merge 1 commit into
react:0.72-stablefrom
hoxyq:hoxyq/cherry-pick-rncore-podspec-fix

Conversation

@hoxyq

@hoxyq hoxyq commented Mar 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

cherry-picking #36571 into 0.72-stable

@hoxyq
fix: update paths in React-rncore.podspec (react#36571)
08b61e9 
Summary:
Pull Request resolved: react#36571

Changelog: [Internal]

The problem is related to the way we use `js_srcs_dir` & `output_dir` options, one requires just relative path from current ruby script, other requires relative path from iOS root project (where the Podfile located)

output_dir was introduced in D43304641
resulted into the issue, described in https://discord.com/channels/514829729862516747/1087736932953509958

allow-large-files

Reviewed By: cipolleschi

Differential Revision: D44294112

fbshipit-source-id: 47fcf510e203d0880e1f92ab6ead09f4b79cb4dd
@hoxyq hoxyq requested review from cipolleschi and kelset March 22, 2023 19:10
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 22, 2023
@github-actions

github-actions Bot commented Mar 22, 2023

Copy link
Copy Markdown
Fails
🚫

❔ This pull request needs a description.
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08b61e9

@analysis-bot

analysis-bot commented Mar 22, 2023

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,519,141 -10
android hermes armeabi-v7a 7,834,736 -494
android hermes x86 8,998,993 -168
android hermes x86_64 8,854,061 -257
android jsc arm64-v8a 9,141,836 +1,326
android jsc armeabi-v7a 8,333,483 +833
android jsc x86 9,196,423 +1,205
android jsc x86_64 9,454,250 +1,082

Base commit: cf43f9c
Branch: main

@cipolleschi

cipolleschi commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

I think we need to look at all the CI failures before we can merge this. :(

@hoxyq

hoxyq commented Mar 27, 2023

Copy link
Copy Markdown
Contributor Author

I think we need to look at all the CI failures before we can merge this. :(

To fix JS ones we need to run prettier, or maybe cherry-pick #36568, where this line is changed

@kelset

kelset commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

yeah don't worry too much about fixing CI with this PR, I was planning to try and tackle it with some local commits

@cipolleschi

cipolleschi commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

@hoxyq @kelset:

  1. Do we still need this?
  2. If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)

@hoxyq

hoxyq commented Mar 29, 2023

Copy link
Copy Markdown
Contributor Author

@hoxyq @kelset:

  1. Do we still need this?
  2. If yes, can we rebase this on top of 0.72-stable to see if the CI stay green? (It should)
  1. Yes
  2. Will do it today

@kelset

kelset commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

headsup: no need for this PR anymore, took care of cherry-picking directly while preparing the branch for RC1: https://github.com/facebook/react-native/commits/0.72-stable

CP here: 7700d7f

@kelset kelset closed this Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cipolleschi cipolleschi Awaiting requested review from cipolleschi

@kelset kelset Awaiting requested review from kelset

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hoxyq @analysis-bot @cipolleschi @kelset @facebook-github-bot