Add support for distributed registration of Fabric Components with Dynamic Libraries#37274
Closed
cipolleschi wants to merge 1 commit into
Closed
Add support for distributed registration of Fabric Components with Dynamic Libraries#37274cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
Base commit: d8ced6f |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
cipolleschi
force-pushed
the
export-D45605441
branch
2 times, most recently
from
61b1f55 to
7f18b34
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
cipolleschi
force-pushed
the
export-D45605441
branch
2 times, most recently
from
c217037 to
a5d9ba3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
cipolleschi
force-pushed
the
export-D45605441
branch
2 times, most recently
from
2391be1 to
debdc1e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
cipolleschi
force-pushed
the
export-D45605441
branch
from
e9ffaba to
19e8c85
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
cipolleschi
force-pushed
the
export-D45605441
branch
from
19e8c85 to
fd71eab
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
cipolleschi
force-pushed
the
export-D45605441
branch
from
fd71eab to
b1ed970
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
cipolleschi
force-pushed
the
export-D45605441
branch
from
b1ed970 to
0f6581b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
cipolleschi
force-pushed
the
export-D45605441
branch
from
0f6581b to
45e8598
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
cipolleschi
force-pushed
the
export-D45605441
branch
from
45e8598 to
a1d2e30
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45605441 |
Contributor
|
This pull request has been merged in b6b09a7. |
This was referenced Aug 22, 2024
jakex7
pushed a commit
to software-mansion/react-native-svg
that referenced
this pull request
Aug 23, 2024
## PR concerning New Architecture support in the library 🎉 We at [Software Mansion](https://swmansion.com/) have been working on [improving support](https://blog.swmansion.com/sunrising-new-architecture-in-the-new-expensify-app-729d237a02f5) for the new architecture for quite a while now. If you need help with anything related to New Architecture, like: - [migrating your library](https://x.com/swmansion/status/1717512089323864275) - [migrating your app](Expensify/App#13767) - [investigating issues](https://github.com/facebook/react-native/pulls?q=sort%3Aupdated-desc+is%3Apr+author%3Aj-piasecki+is%3Aopen) - [improving performance](https://x.com/BBloniarz_/status/1808138585528303977) or you just want to ask any questions, hit us up on [projects@swmansion.com](mailto:projects@swmansion.com) --- ## Summary <!-- Simple summary of what was changed. --> PR adding `load` method needed for dynamic frameworks to work with the library. See react/react-native#37274 for more information.
kirillzyusko
pushed a commit
to kirillzyusko/react-native-keyboard-controller
that referenced
this pull request
Aug 23, 2024
## PR concerning New Architecture support in the library 🎉 We at [Software Mansion](https://swmansion.com/) have been working on [improving support](https://blog.swmansion.com/sunrising-new-architecture-in-the-new-expensify-app-729d237a02f5) for the new architecture for quite a while now. If you need help with anything related to New Architecture, like: - [migrating your library](https://x.com/swmansion/status/1717512089323864275) - [migrating your app](Expensify/App#13767) - [investigating issues](https://github.com/facebook/react-native/pulls?q=sort%3Aupdated-desc+is%3Apr+author%3Aj-piasecki+is%3Aopen) - [improving performance](https://x.com/BBloniarz_/status/1808138585528303977) or you just want to ask any questions, hit us up on [projects@swmansion.com](mailto:projects@swmansion.com) --- ## Summary <!-- Simple summary of what was changed. --> PR adding `load` method needed for dynamic frameworks to work with the library. See react/react-native#37274 for more information.
WoLewicki
added a commit
to software-mansion/react-native-screens
that referenced
this pull request
Aug 26, 2024
PR adding load method needed for dynamic frameworks to work with the library. See react/react-native#37274 for more information.
WoLewicki
added a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Aug 30, 2024
PR adding `load` method needed for dynamic frameworks to work with the library. See react/react-native#37274 for more information.
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
PR adding load method needed for dynamic frameworks to work with the library. See react/react-native#37274 for more information.
kkafar
pushed a commit
to software-mansion/react-native-screens
that referenced
this pull request
Oct 25, 2024
PR adding load method needed for dynamic frameworks to work with the library. See react/react-native#37274 for more information. (cherry picked from commit 29c98e2)
8 tasks
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With dynamic frameworks, we can't use floating C functions.
The way in which dynamic frameworks work is that they need to be self contained. They are built in isolation so that other frameworks can be linked against them to solve their dependencies.
Currently, when working with 3rd party libraries, we are Codegenerating a RCTThirdPartyComponentProvider which tries to invoke floating C functions that are defined in other modules. React-RCTFabric has no visibility on those modules, therefore it fails building.
The implemented solution exclude the generation of those symbols and leverage a the Objective-C runtime to automatically register libraries when they are loaded.
This mechanism is applied ONLY when the flag RCT_DYNAMIC_FRAMEWORKS is turned on. There will be no impact on internal meta apps, nor on any apps that are not using Dynamic Frameworks.
This change requires a small migration in all the Fabric components libraries that wants to support dynamic frameworks. They have to implement a
method in their ComponentView.
Not to slow down the adoption of the new architecture, waiting for a migration in the ecosystem, the next diff introduce a secondary, declarative loading mechanism for Fabric Components, which follows the same approach used by TurboModules.
Changelog:
[iOS][Changed] - Add support for distributed registration of Fabric Components with Dynamic Libraries.
Notes that this change is NOT breaking as dynamic frameworks were not working before in the New Architecture. Static Libraries and Static Frameworks continue working as usual.
Differential Revision: D45605441