Skip to content

Re-enable iOS integration tests#37571

Closed
cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D46178840
Closed

Re-enable iOS integration tests#37571
cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D46178840

Conversation

@cipolleschi

Copy link
Copy Markdown
Contributor

Summary:
During the RC.0 of 0.72, we disabled the iOS integration tests because they were not working with Metro and the new Monorepo setup.

This change tries to re-enable them so we can be more protected in CI

Changelog:

[internal] - Re-enable integration tests

Differential Revision: D46178840

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 25, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D46178840

@analysis-bot

analysis-bot commented May 25, 2023

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,740,158 +2
android hermes armeabi-v7a 8,051,270 +6
android hermes x86 9,230,364 +0
android hermes x86_64 9,081,999 +4
android jsc arm64-v8a 9,302,096 +3
android jsc armeabi-v7a 8,490,792 +2
android jsc x86 9,363,380 +2
android jsc x86_64 9,619,126 +2

Base commit: 1a1e399
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D46178840

@cipolleschi cipolleschi force-pushed the export-D46178840 branch 2 times, most recently from 2c2204e to 6701f2a Compare May 25, 2023 10:10
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D46178840

Summary:
Pull Request resolved: #37571

During the RC.0 of 0.72, we disabled the iOS integration tests because they were not working with Metro and the new Monorepo setup.

This change tries to re-enable them so we can be more protected in CI

## Changelog:
[internal] - Re-enable integration tests

Reviewed By: cortinico

Differential Revision: D46178840

fbshipit-source-id: e903c0e3ed8a28cd7ef009ae23301b714b333c64
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D46178840

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 25, 2023
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in bdeb09b.

amgleitman pushed a commit to amgleitman/react-native-macos that referenced this pull request Aug 18, 2023
Summary:
Pull Request resolved: react#37571

During the RC.0 of 0.72, we disabled the iOS integration tests because they were not working with Metro and the new Monorepo setup.

This change tries to re-enable them so we can be more protected in CI
[internal] - Re-enable integration tests

Reviewed By: cortinico

Differential Revision: D46178840

fbshipit-source-id: a5239fa7067b8fb68d997dd0cc63b67fb54d2d7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants