Simplify occupied port handling in start command#39078
Closed
huntie wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48433285 |
Base commit: 8b62200 |
huntie
force-pushed
the
export-D48433285
branch
from
df85cd3 to
c3ad261
Compare
huntie
force-pushed
the
export-D48433285
branch
from
c3ad261 to
c961104
Compare
huntie
force-pushed
the
export-D48433285
branch
from
c961104 to
24d6eb4
Compare
huntie
force-pushed
the
export-D48433285
branch
from
24d6eb4 to
ff54c7c
Compare
huntie
force-pushed
the
export-D48433285
branch
from
ff54c7c to
874a66e
Compare
huntie
force-pushed
the
export-D48433285
branch
from
874a66e to
8fcb34b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48433285 |
huntie
force-pushed
the
export-D48433285
branch
from
8fcb34b to
5645f96
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48433285 |
huntie
force-pushed
the
export-D48433285
branch
from
5645f96 to
8d70691
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48433285 |
huntie
force-pushed
the
export-D48433285
branch
from
8d70691 to
2b53149
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48433285 |
huntie
force-pushed
the
export-D48433285
branch
from
2b53149 to
d80873d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48433285 |
huntie
force-pushed
the
export-D48433285
branch
from
d80873d to
f39483d
Compare
Summary: Follow-up to react#38988. - Upgrade to RN CLI `12.0.0-alpha.10`. - Restore previous value check against `/status` response in test scripts (restored in above CLI alpha). Changelog: [Internal] Differential Revision: https://internalfb.com/D48432629 fbshipit-source-id: 755be14a954c28f807eed94238e9f3497fdda9c0
Summary: Pull Request resolved: react#39075 Small refactor: reorganise command entry points and types into a consistent pattern. Changelog: [Internal] Differential Revision: https://internalfb.com/D48433284 fbshipit-source-id: 5cc145b474c8c5cbf350cfee1a1b92091afd9b18
Summary: Pull Request resolved: react#39078 Simplifies and hardens behaviour for detecting other processes / dev server instances when running `react-native start`. - New flow: - Exits with error message if port is taken by another process (*no longer suggests next port*). - Exits with info message if port is taken by another instance of this dev server (**unchanged**). - Continues if result unknown. - *(No longer logs dedicated message for another RN server running in a different project root.)* - This now checks if the TCP port is in use before attempting an HTTP fetch. Previous behaviour: [`handlePortUnavailable`](https://github.com/react-native-community/cli/blob/734222118707fff41c71463528e4e0c227b31cc6/packages/cli-tools/src/handlePortUnavailable.ts#L8). This decouples us from some lower-level `react-native-community/cli-tools` utils, which remain reused by the `android` and `ios` commands. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48433285 fbshipit-source-id: 22ed8b050a6ce729d19cc46da377697547a32582
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: react#39078 Simplifies and hardens behaviour for detecting other processes / dev server instances when running `react-native start`. - New flow: - Exits with error message if port is taken by another process (*no longer suggests next port*). - Exits with info message if port is taken by another instance of this dev server (**unchanged**). - Continues if result unknown. - *(No longer logs dedicated message for another RN server running in a different project root.)* - This now checks if the TCP port is in use before attempting an HTTP fetch. Previous behaviour: [`handlePortUnavailable`](https://github.com/react-native-community/cli/blob/734222118707fff41c71463528e4e0c227b31cc6/packages/cli-tools/src/handlePortUnavailable.ts#L8). This decouples us from some lower-level `react-native-community/cli-tools` utils, which remain reused by the `android` and `ios` commands. Changelog: [Internal] Differential Revision: https://internalfb.com/D48433285 fbshipit-source-id: c893444eafc19dd3bfc7cc91995550f6e8372e3f
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48433285 |
huntie
force-pushed
the
export-D48433285
branch
from
f39483d to
bcf41d8
Compare
Contributor
|
This pull request has been merged in 13eda31. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Simplifies and hardens behaviour for detecting other processes / dev server instances when running
react-native start.Previous behaviour:
handlePortUnavailable. This decouples us from some lower-levelreact-native-community/cli-toolsutils, which remain reused by theandroidandioscommands.Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D48433285