Fix ScrollView onScroll event only being called once.

[chrene]

No description provided.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

[tadeuzagallo]

@nicklockwood I think you wrote the TODO, is that right?
I don't think 0 should be the default value...

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[sahrens]

We don't want to send the events by default, and we want the client to think about what frequency they need the events. If the parent specifies onScroll and not the frequency, perhaps we should redbox?

On Mar 29, 2015, at 12:00 PM, Tadeu Zagallo notifications@github.com wrote:

@nicklockwood I think you wrote the TODO, is that right?
I don't think 0 should be the default value...

—
Reply to this email directly or view it on GitHub.

[tadeuzagallo]

@sahrens it might have been my fault, I was talking @chrene on IRC and he said it was a bug, and I totally forgot that we needed to set the property for it to work.
If we set the property is working as expected? Because if it is maybe we should remove that comment.

[chrene]

The only real bug was just that it was a double when it should have been a NSUInteger. Since it was a double it got a very very high number when set. Like 4 billion or something. Now it gets the real value. We can keep the check in the if statement such that the client needs to specify another value than 0.

[tadeuzagallo]

nit: this indentation was right...

[tadeuzagallo]

I tested it and it's working as expected, but @sahrens I tried adding an invariant instead of the current warning, and during testing it on UIExplorer I just noticed that an invariant during a NavigatorIOS push crashes the objC... Any idea about that? Should we add the invariant anyways?

[sahrens]

If there is already a warning we can leave it.

On Mar 29, 2015, at 5:20 PM, Tadeu Zagallo notifications@github.com wrote:

I tested it and it's working as expected, but @sahrens I tried adding an invariant instead of the current warning, and during testing it on UIExplorer I just noticed that an invariant during a NavigatorIOS push crashes the objC... Any idea about that? Should we add the invariant anyways?

—
Reply to this email directly or view it on GitHub.

[nicklockwood]

I submitted a fix for this today that changes the property type to NSTimeInterval and renames the property to scrollEventThrottle, which seems more logical. That also fixes the issue with the default value being set incorrectly.

[sahrens]

This should be fixed in master - please open an issue if still see the bug.